-
Notifications
You must be signed in to change notification settings - Fork 73
Add new MongoDownloader tool #109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
cdeef71
to
e075c62
Compare
I have tested the downloader on both on macOS and Windows so I'm pretty confident it works well. I tried to run the tests with the new binaries and I encountered a problem: the logs are now in JSON format and the
Some more work needs to be done for the tests to pass. |
7b7aeef
to
0fb3008
Compare
This tool automates the download of latest MongoDB binaries (_MongoDB Community Server_ and _MongoDB Database Tools_) for Linux, macOS and Windows. * _MongoDB Community Server_ contains the `mongod` binary. * _MongoDB Database Tools_ contains the `mongoexport` and `mongoimport` binaries. Then it merges the binaries into a `bin` directory for each platform and moves other files into `community-server` and `database-tools` directories. Here is how the layout of the `tools` directory looks like after downlading and extracting files for _MongoDB Community Server_ 4.4.3 and _MongoDB Database Tools_ 100.2.1: ``` . ├── README.md ├── mongodb-linux-4.4.3-database-tools-100.2.1 │ ├── bin │ │ ├── mongod │ │ ├── mongoexport │ │ └── mongoimport │ ├── community-server │ │ ├── LICENSE-Community.txt │ │ ├── MPL-2 │ │ ├── README │ │ └── THIRD-PARTY-NOTICES │ └── database-tools │ ├── LICENSE.md │ ├── README.md │ └── THIRD-PARTY-NOTICES ├── mongodb-macos-4.4.3-database-tools-100.2.1 │ ├── bin │ │ ├── mongod │ │ ├── mongoexport │ │ └── mongoimport │ ├── community-server │ │ ├── LICENSE-Community.txt │ │ ├── MPL-2 │ │ ├── README │ │ └── THIRD-PARTY-NOTICES │ └── database-tools │ ├── LICENSE.md │ ├── README.md │ └── THIRD-PARTY-NOTICES └── mongodb-windows-4.4.3-database-tools-100.2.1 ├── bin │ ├── mongod.exe │ ├── mongoexport.exe │ └── mongoimport.exe ├── community-server │ ├── LICENSE-Community.txt │ ├── MPL-2 │ ├── README │ └── THIRD-PARTY-NOTICES └── database-tools ├── LICENSE.md ├── README.md └── THIRD-PARTY-NOTICES ``` Fixes Mongo2Go#82
f50947a
to
96c4997
Compare
Also remove the AssemblyInfo.cs file and have everything in the csproj instead.
The `transition to primary complete` message in recent mongod versions now starts with a capital `T`.
* MongoDB Community Server 4.4.4 * MongoDB Database Tools 100.3.0 This is required for the tests to pass since the search patterns in the `MongoBinaryLocator` have been updated to match the new MongoDB naming scheme.
All the tests are now passing with the latest MongoDB server (4.4.4) on macOS. On Windows, I get the following error in when using commands that create console output → should not timeout:
According to https://jira.mongodb.org/browse/SERVER-37726 this issue should be fixed in MongoDB 4.3.4 so maybe that's an issue with the C# driver? To verify that the binaries committed in a55bd18 are the original ones, delete the 3 directories in the
You should see that the git repository has no diff if the latest versions are still MongoDB Community Server 4.4.4 and MongoDB Database Tools 100.3.0. |
Awesome work!!! =)
I don't see any issue in updating the C# driver, if this fixes the tests. The nuget package itself has no external dependencies (including the c# driver) at all. |
The thing is, the tests are not fixed on Windows. 🙁 They pass 100% only on macOS (I haven't tested on Linux). Can you try yourself on Windows? Do yo get the same |
Have you had a chance to test with the latest version of MongoDB? |
Fixed! 🎉 |
@0xced I pushed v3 to nuget. Please give it a try! Many thanks for your support! 🙂👍 |
Awesome, thanks for merging and releasing a new version on NuGet, it works like a charm. 🎉 |
I thank you for making it all possible. Great job! 👍 |
This tool automates the download of latest MongoDB binaries (MongoDB Community Server and MongoDB Database Tools) for Linux, macOS and Windows.
mongod
binary.mongoexport
andmongoimport
binaries.Then it merges the binaries into a
bin
directory for each platform and moves other files intocommunity-server
anddatabase-tools
directories.Here is how the layout of the
tools
directory looks like after downlading and extracting files for MongoDB Community Server 4.4.3 and MongoDB Database Tools 100.2.1:Fixes #82