Skip to content

Conversation

loriab
Copy link
Collaborator

@loriab loriab commented Sep 22, 2022

Description

Develop stdsuite further for Psi4 and QCDB testing.

Changelog description

  • Cfour
    • parsing for BCCD and BCCD(T)
  • Gamess
    • CHANGE saving ROHF MP2 ZAPT quantities from MP2 to ZAPT qcvars
    • stop saving HF TOTAL ENERGY qcvar in DFT calcs, as it's not canonical HF energy
  • NWChem
    • run b2plyp and parse and save dhdft qcvars correctly
    • collect cc2
  • Refs and stdsuite
    • create different sections in ref storage for standard orbitals (SD) and semicanonical (SC) orbitals for CONV-AE-CONV and CONV-FC-CONV. SD's are small sections, and for AE, largely a copy from SC. This enables detangling CCSD and CCSD(T) reference duels that arise (1) because there are multiple legitimate formulations, esp. for FC ROHF and (2) while nearly all programs only produce SC CCSD(T), for CCSD programs produce only SC, only SD, or both, with varying defaults.
    • by default, SD sections are chosen for RHF and UHF and SC sections for ROHF. any downstream project using the stdsuite interface will need to add an extra argument.
    • add qcvars contracts for ZAPT2, CEPA(1), CEPA(3), ACPF, AQCC, BCCD, BCCD(T), CC2, and CC3
    • add qcvars contracts for DHDFT and check that it and plain DFT aren't setting HF and MP2 qcvars on non-canonical quantities
    • add references for the methods above mostly in CONV
    • in DF/CD, add refs for CCD and SVWN, WB97X, B2PLYP DFTs.

Status

  • Code base linted
  • Ready to go

@codecov
Copy link

codecov bot commented Sep 22, 2022

Codecov Report

Merging #376 (bcfa5f1) into master (7f8c58a) will decrease coverage by 0.82%.
The diff coverage is 18.40%.

Additional details and impacted files

@lgtm-com
Copy link
Contributor

lgtm-com bot commented Sep 22, 2022

This pull request introduces 1 alert when merging 530f1ef into 2793f58 - view on LGTM.com

new alerts:

  • 1 for Unused local variable

@loriab loriab mentioned this pull request Sep 29, 2022
49 tasks
@lgtm-com
Copy link
Contributor

lgtm-com bot commented Oct 10, 2022

This pull request introduces 1 alert when merging 817cd10 into 2793f58 - view on LGTM.com

new alerts:

  • 1 for Unused local variable

@lgtm-com
Copy link
Contributor

lgtm-com bot commented Oct 10, 2022

This pull request introduces 1 alert when merging 51f9119 into 2793f58 - view on LGTM.com

new alerts:

  • 1 for Unused local variable

@lgtm-com
Copy link
Contributor

lgtm-com bot commented Oct 25, 2022

This pull request introduces 1 alert when merging 2c78a29 into 7f8c58a - view on LGTM.com

new alerts:

  • 1 for Unused local variable

@loriab loriab force-pushed the stdsuite_refs_for_dfocc_5 branch from 2c78a29 to 69c85b0 Compare October 25, 2022 04:57
@lgtm-com
Copy link
Contributor

lgtm-com bot commented Oct 25, 2022

This pull request introduces 1 alert when merging 69c85b0 into 7f8c58a - view on LGTM.com

new alerts:

  • 1 for Unused local variable

@lgtm-com
Copy link
Contributor

lgtm-com bot commented Oct 31, 2022

This pull request introduces 1 alert when merging eed68e9 into 7f8c58a - view on LGTM.com

new alerts:

  • 1 for Unused local variable

@lgtm-com
Copy link
Contributor

lgtm-com bot commented Nov 1, 2022

This pull request introduces 1 alert when merging bcfa5f1 into 7f8c58a - view on LGTM.com

new alerts:

  • 1 for Unused local variable

Copy link
Collaborator

@dotsdl dotsdl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me @loriab! Please merge when ready!

@loriab loriab merged commit 17248bb into MolSSI:master Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants