Skip to content

Conversation

dkimitsa
Copy link
Contributor

@dkimitsa dkimitsa commented May 29, 2019

This PR fixes wrongly attached marshalers all over cocoa touch bindings.
it is related to #373
Cocoa touch bindings were done with updated dkimitsa/bro-gen

What have been done:

  • bro-gen was updated to generate proper marshaler automaticaly.
  • yaml files were inspected and all not required marshaler directives (ones that bro-gen can recognize) were removed.
  • most iOS SDK migrate to defining enums with NS_ENUM which simplified configuration of ones in yaml. Yamls were cleaned up from not required any more configuration data.
  • all bindings were re-generated.

Update July/4
I've pushed to this PR also changes done due July update of bro-gen, this adds:

  • cosmetic movement of @Deprecated annotation to proper place
  • yaml files fixed to match bro-gen fixes
  • few more methods were annotated as deprecated

Probably might introduce breaking changes.

@dkimitsa
Copy link
Contributor Author

there are few more technical details in post: https://dkimitsa.github.io/2019/05/29/binding-enum-marshalers/

* unhidden  `-init` methods which become hidden after fix in bro-gen
* attached few deprecated annotation extracted from __deprecated_msg/__deprecated
* cosmetic: @deprecated annotation moved from JavaDoc to Annotation sections
@dkimitsa dkimitsa changed the title cocoa touch: fixed marshalers cocoa touch: fixed marshalers + regenerated with recent bro-get Jul 4, 2019
@Tom-Ski Tom-Ski merged commit 947f265 into MobiVM:master Jul 4, 2019
@dkimitsa dkimitsa deleted the fix_marshalers branch July 4, 2019 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants