-
Notifications
You must be signed in to change notification settings - Fork 136
cocoa touch: fixed marshalers + regenerated with recent bro-get #377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…halers to OSStatus enums
…ect generated java files
…ect generated java files
there are few more technical details in post: https://dkimitsa.github.io/2019/05/29/binding-enum-marshalers/ |
* unhidden `-init` methods which become hidden after fix in bro-gen * attached few deprecated annotation extracted from __deprecated_msg/__deprecated * cosmetic: @deprecated annotation moved from JavaDoc to Annotation sections
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes wrongly attached marshalers all over cocoa touch bindings.
it is related to #373
Cocoa touch bindings were done with updated dkimitsa/bro-gen
What have been done:
NS_ENUM
which simplified configuration of ones in yaml. Yamls were cleaned up from not required any more configuration data.Update July/4
I've pushed to this PR also changes done due July update of bro-gen, this adds:
@Deprecated
annotation to proper placeProbably might introduce breaking changes.