Fix for Invalid Swift Support issue
#346
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…loading to AppleStore. root case assumed: during MobiVM#340 there was introduced defect that swift libs copy in 'SwiftSupport' also get stripped of ARM64E arch as result copy of these files were modified. As part of fix this commit does: * fixed issue with modifying of swift libs in 'SwiftSupport' * now all dynamic frameworks/libs/appext are being stripped to keep only archs same as in app (similar fix done in [rules_apple](bazelbuild/rules_apple@b238ee5)). This also reduce final IPA size * as all extra arches are being stripped introduced in MobiVM#340 `stripArchs` option is not required anymore and was removed * added functionality to strip bitcode from frameworks/libs/appext similar how XCode does, it also saves final IPA size
|
…ked from target.defaultArchs
… SwiftSupport then. Reverting to removing 'ARM64E' only which seems to be valid case
|
approach to strip every not used arch slice was bad, Apple rejects such SwiftSupport. Reverted back to removing simulator archs and ARM64E which seems to be working for me |
|
This fixes our issue with an advertising library that required the swift support libs, and the failed "does not match" swift validation email from apple testflight. |
|
@dkimitsa thanks once again! Is this mergeable? |
|
@florianf it seems to be working for me and Eric, but having more confirmation appreciated, changing thing is strip bitcode on dynamic frameworks, didnt test it on framework without bitcode, this is the only moment |
|
checked bitcode_strip on dynamic lib without bitcode -- doesn't fail. seems to be ok |
|
Thx! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update: works for me, works for topic starter (Eric Nondahl).
This shell fix
Invalid Swift Supportissue when uploading to AppleStore.root case assumed: during #340 there was introduced defect that swift libs copy in 'SwiftSupport' also get stripped of ARM64E arch as result copy of these files were modified. As part of fix this commit does:
now all dynamic frameworks/libs/appext are being stripped to keep only archs same as in app (similar fix done in [rules_apple] (bazelbuild/rules_apple@b238ee5)). This also reduce final IPA sizeUPDATE: reverted to strip only ARM64Eas all extra arches are being stripped introduced in fix #338 -- removing arch64e #340UPDATE: this option was removed as well as it is enough only to strip ARM64EstripArchsoption is not required anymore and was removed`