Skip to content

Conversation

dkimitsa
Copy link
Contributor

  • added option for robovm.xml to strip extra arches, e.g.
<stripArchs>
   <arch>zx48</arch>
</stripArchs>
  • when building ipa arm64e is forced to be removed

* when building ipa arm64e is forced to be removed
@florianf florianf merged commit aad0369 into MobiVM:master Dec 14, 2018
dkimitsa added a commit to dkimitsa/robovm that referenced this pull request Jan 21, 2019
…loading to AppleStore.

root case assumed: during MobiVM#340 there was introduced defect that swift libs copy in 'SwiftSupport' also get stripped of ARM64E arch as result copy of these files were modified. As part of fix this commit does:
* fixed issue with modifying of swift libs in 'SwiftSupport'
* now all dynamic frameworks/libs/appext are being stripped to keep only archs same as in app (similar fix done in [rules_apple](bazelbuild/rules_apple@b238ee5)). This also reduce final IPA size
* as all extra arches are being stripped introduced in MobiVM#340 `stripArchs` option is not required anymore and was removed
* added functionality to strip bitcode from frameworks/libs/appext similar how XCode does, it also saves final IPA size
florianf pushed a commit that referenced this pull request Jan 28, 2019
* TO BE CONFIRMED: This shell fix `Invalid Swift Support` issue when uploading to AppleStore.
root case assumed: during #340 there was introduced defect that swift libs copy in 'SwiftSupport' also get stripped of ARM64E arch as result copy of these files were modified. As part of fix this commit does:
* fixed issue with modifying of swift libs in 'SwiftSupport'
* now all dynamic frameworks/libs/appext are being stripped to keep only archs same as in app (similar fix done in [rules_apple](bazelbuild/rules_apple@b238ee5)). This also reduce final IPA size
* as all extra arches are being stripped introduced in #340 `stripArchs` option is not required anymore and was removed
* added functionality to strip bitcode from frameworks/libs/appext similar how XCode does, it also saves final IPA size

* * fixed case when archs are not specified in config file, then it picked from target.defaultArchs

* * removed reference to dead code in Idea classes

* * approach to leave only used arch seems to be wrong as apple rejects SwiftSupport then. Reverting to removing 'ARM64E' only which seems to be valid case
@dkimitsa dkimitsa deleted the fix_338_extra_arm64e branch February 14, 2019 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants