Skip to content

Conversation

dkimitsa
Copy link
Contributor

@dkimitsa dkimitsa commented Nov 9, 2018

These was massive API update as part of iOS12 release which includes new frameworks:

  • AuthenticationServices
  • CarPlay
  • CoreServices
  • IdentityLookupUI
  • NaturalLanguage
  • Network

Also this release delivers lot of API changes to existing framework which, bright highlights are:

  • ARKit 2
  • Metal Performance Shaders;
  • and others

Beside updating API itself cocoatouch receives lot of patches as result of improvement of bro-gen script.

Following was improved:

  • fixed lot of broken enum entires (names were generated cut or prefix was not determinated);
  • exposed missing inherited constructors which added lot of missing constructors;
  • applied inherited configuration that reduce number of config entries to be put in yaml;
  • methods where WithXX was generated were mostly located and correctly renamed (this probably might be a breaking change);
  • lot of different minor fixes in generator;

I keep testing some part of it. Please also check if nothing is broken in libgdx

@florianf
Copy link
Collaborator

@Tom-Ski could you test the libgdx side?

@mustii82
Copy link

@dkimitsa Amazing Work!!!

@dkimitsa
Copy link
Contributor Author

@florianf @Tom-Ski I still plan to test few more cases, also plan to close several issues. lets keep testing.

@costimuraru
Copy link

nice work 👍

…found for return type of @globalvalue method` which happens for globals that operates with blocks. Following code crashes compilation without this change. It wasn't found early as nobody had been using global value that returns a block.

```
    @globalvalue(symbol="_nw_parameters_configure_protocol_default_configuration", optional=true)
    public static native @block VoidBlock1<NWProtocolOptions> DEFAULT_CONFIGURATION();
```
- generated constant blocks for configurations that were missing
- added string marshalers to make api more friendly
- fixed underlines in names
- NWParameters.copy renamed to NWParameters.copyParameters as otherwise it cause bridge synthetic copy method generated from NSObject that caused `@Bridge annotated method must be native` on it
@dkimitsa
Copy link
Contributor Author

@florianf @Tom-Ski I've completed activities, please check and point if there is any issues.
thanks

@florianf florianf merged commit a546ca9 into MobiVM:master Nov 27, 2018
@florianf
Copy link
Collaborator

Thanks a bunch!!

@dkimitsa
Copy link
Contributor Author

hi @florianf
it also fixes #324

@dkimitsa dkimitsa deleted the ios12-bindings branch December 11, 2018 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants