Skip to content

Conversation

dkimitsa
Copy link
Contributor

@dkimitsa dkimitsa commented Jun 1, 2018

Root case is SDK field is not being set in LC_VERSION_MIN_IPHONEOS MACHO command.
Commit fixes following:

  • adds sdk_version VERSION linker command to explicitly specify version. this is only required fix
  • also changes soring logic when compares iPhone.sdk with latest iPhone11.4.sdk (symb link to iPhone.sdk) to give iPhone.sdk one lower priority. So it will not go as sysroot.

…app updates submitted to the App Store will need to be built with the iOS '11.0' SDK or later, included in Xcode [9.0] or later"

Root case is SDK field is not being set in LC_VERSION_MIN_IPHONEOS MACHO command. Read post for technical details:
 https://dkimitsa.github.io/2018/01/30/linux-windows-not-a-bug-error-in-compatibility-flow/

Commit fixes following:
* adds `sdk_version VERSION` linker command to explicitly specify version. this is only required fix
* also changes soring logic when compares iPhone.sdk with latest iPhone11.4.sdk (symb link to iPhone.sdk) to give iPhone.sdk one lower priority. So it will not go as sysroot.
@dkimitsa
Copy link
Contributor Author

dkimitsa commented Jun 1, 2018

@dkimitsa
Copy link
Contributor Author

dkimitsa commented Jun 1, 2018

lets wait for confirmation from Kees van Dieren side

@dkimitsa
Copy link
Contributor Author

dkimitsa commented Jun 2, 2018

seems that approach/fix is confirmed, check gitter channel

@dkimitsa dkimitsa mentioned this pull request Jun 2, 2018
3 tasks
@florianf florianf merged commit c216a58 into MobiVM:master Jun 4, 2018
@dkimitsa dkimitsa deleted the ITMS-90725-fix branch June 8, 2018 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants