Bugfix 286 285 and clear cache on new snapshot #289
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tart extracting same file 2) if any file was updated -- clean cache
|
Perfect, thx! |
There was a problem hiding this comment.
I also tried to make it clear my ~/.robovm/cache, but it did not work as I would have expected. Here is what I did:
- clone github.com/MobiVM/robovm
- run
mvn clean install - run
cd plugins/gradle - run
./gradlew install - create a new project using gdx-setup.jar, only check 'ios' platform
- import this project in IDE
- in build.gradle, change plugin dependency to
com.mobidevelop.robovm:robovm-gradle-plugin:2.3.4-SNAPSHOTandroboVMVersion = '2.3.4-SNAPSHOT' - in ios/build.gradle, inside
robovmtag, add: iosSkipSigning = true - run ./gradlew createIPA
Observations:
ls -sathl ~/.robovm/still shows last modified date of12 Oct 2017.
I think this should have cleared the cache dir?
| @@ -416,16 +417,18 @@ public static Sdk getSdk() { | |||
| private static void extractArchive(String archive, File dest) { | |||
| archive = "/" + archive; | |||
| TarArchiveInputStream in = null; | |||
| boolean isSnapshot = Version.getVersion().toLowerCase().contains("snapshot"); | |||
| // boolean isSnapshot = Version.getVersion().toLowerCase().contains("snapshot"); | |||
There was a problem hiding this comment.
@dkimitsa this can be removed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
there are three commits:
1 - fixes #286 by completing #287 in sake of delivering the fix
2- fixes #285 -- obeys not @NotNull otherwise idea halt the plugin
3- adds logic not extracting same file on every launch and do clear cache when new files extracted just to avoid bug cases when incompatible data stays in cache, check post by @dthommes