* fix: support for classes compiled with Java18 (JDK-8272564) #672
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when Java18 used as compiler JDK-8272564 changes will be applied this will affect invocation of java.lang.Object methods on interface receivers. as per changes invokevirtual is replaced with invokeinterface and these methods has to be resolved as per https://docs.oracle.com/javase/specs/jvms/se17/html/jvms-5.html#jvms-5.4.3.4 item 3 in RoboVM case this means that final methods of "java.lang.Object" has to be available for lookup, thus changes added to include [lookup] wrappers for final methods in this case otherwise it will fail during linking with message(s): > Undefined symbols for architecture arm64:"[j]java.lang.Object.notifyAll()V[lookup]"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2.3.17 release failed due this, discussion in gitter
root case
when Java18 used as compiler JDK-8272564 changes will be applied this will affect invocation of
java.lang.Object methods on interface receivers.
as per changes invokevirtual is replaced with invokeinterface and these methods
has to be resolved as per https://docs.oracle.com/javase/specs/jvms/se17/html/jvms-5.html#jvms-5.4.3.4 item 3
in RoboVM case this means that final methods of "java.lang.Object" has to be available for lookup,
thus changes added to include [lookup] wrappers for final methods in this case
otherwise it will fail during linking with message(s):