* Memory usage optimization (2/2): reduced number of produced string #651
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Compiler produces LLVM IR `.ll` file from Java class file. It's a text file and compiler converts instructions into strings and concatenates everything into one big text file. During operation, it produces thousands of string and glues them together. There was a [case]({{ site.baseurl }}{% post_url 2020-05-25-fix-oom-big-classes %}) recently when 4GB string was tried to be built.
All these strings in results are being written into destination byte buffer using `Writer`.
Optimization here is to make all entities to write itself directly to `Writer` instead of producing strings.
Closed
# Conflicts: # compiler/compiler/src/main/java/org/robovm/compiler/llvm/StructureConstant.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a fix of #150
It doesn't fix memory consumption but make life of GC a bit easier as millions of strings are not being constructed.
Changes
Compiler produces LLVM IR
.llfile from Java class file. It's a text file and compiler converts instructions into strings and concatenates everything into one big text file. During operation, it produces thousands of string and glues them together.All these strings in results are being written into destination byte buffer using
Writer.Optimization here is to make all entities to write itself directly to
Writerinstead of producing intermediate strings.