* fix for ld: unaligned pointer(s) for architecture arm64
#639
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. attribute/class info structs: these are now generated to be not packed (will consume a bit more ram) 2. VM code updated to new structure layouts 3. Debugger code updated to new structure layouts
|
also for 2.3.17 |
- `-w` that was suppressing all warnings - `-no_pie` -- as it is not supported for arm targets (and debugger can handle it) - `-sdk_version` as linker picks one from `platform_version`
|
a bit more details |
…pointers # Conflicts: # plugins/debugger/src/main/java/org/robovm/debugger/utils/bytebuffer/DataBufferReader.java
|
@dkimitsa Thank you for fixing this! |
dkimitsa
added a commit
to dkimitsa/robovm
that referenced
this pull request
Aug 5, 2022
introduced by MobiVM#639 root case: struct member alignment was wrongly calculated for jlong and double: was calculated as aligned by member size (8 bytes) but has to be 4 byte boundary. fix: use `offsetof` to get data layout offsets
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Memory footprint affected
as information structures are not packed it will increase memory requirement to keep these.
On sample project it increases size of structs from
5525197to6935824bytes or by25%removed linker flags
-wthat was suppressing all warnings-no_pie-- as it is not supported for arm targets (and debugger can handle it)-sdk_versionas linker picks one fromplatform_version