* CocoaTouch: NSObjectProtocol reverted in sake of NSObject #632
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Root case(s): 1. some apis return id<nsobject> and accept back id. In case of RoboVM 2.3.16 bind these types as following: * id<nsobject> -> NSObjectProtocol * id -> NSObject 2. there is significant moment: CocoaTouch defines all NSObject apis in NSObject protocol and keeps NSObject class empty. While RoboVM has opposite implementation: NSObjectProtocol is empty 3. RoboVM handle retain/release for NSObject subclasses and there is might be issues with NSObjectProtocol
dkimitsa
added a commit
to dkimitsa/robovm
that referenced
this pull request
Aug 27, 2022
PR MobiVM#632 already reverted NSObjectProtocol back to NSObject using regenerated bindings by bro-gen. But there was amount of manual changes, and this the fix is to revert corresponding commit: MobiVM@002b53b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix for #629
Root case(s):
In case of RoboVM 2.3.16 bind these types as following:
there is significant moment: CocoaTouch defines all NSObject apis in NSObject protocol and keeps NSObject class empty. While RoboVM has opposite implementation: NSObjectProtocol is empty
RoboVM handle retain/release for NSObject subclasses and there is might be issues with NSObjectProtocol