* revert of #589 to fix 'duplicate symbol xxx.spfpoffset' #626
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reverted MobiVM#589 as it wasn't fixing the root case but only symptoms. And was introducing another problem reported on [gitter](https://gitter.im/MobiVM/robovm?at=620934c66e4c1e1c8461d1cf) Root case was exported symbol masks `*GAD*` and `*DFP*` in alt-pod configuration for Google Mobile Ads that were keeping trampolins funciton from being eliminated by `dead_strip` Alt-pods were [fixed](dkimitsa/robovm-robopods@b220a4f) and re-deployed as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverted #589 as it wasn't fixing the root case but only symptoms. And was introducing another problem reported on gitter
Root case was exported symbol masks
*GAD*and*DFP*in alt-pod configuration for Google Mobile Ads that were keeping trampolins funciton from being eliminated bydead_stripAlt-pods were fixed and re-deployed as well