framework target: producing xcframework #623
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adds support for extended `arch` strings to support strings like `arm64-simulator`. its required to allow framework targets to be built with `arm64-simulator` slice. to achieve this: - `Arch` enum was renamed into `CpuArch`; - instead `Arch` class was introduced that combines both `CpuArch` and `Environment` enums
- combining device arches and simulator ones into separate binaries - for each binary standalone structure of framework is generated with own set of resources - structure of xcframework with info.plist is generated
…h specified host where LLVM lib was compiled, not actually host it is now running on.
As result it affected default arch selection for Console/Framework targets
Reworked to use `System.getProperty("os.arch")`
…lator run dialog
Tom-Ski
approved these changes
Feb 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
problem
arm64-simulatorslice as only<arch>arm64</arch>was allowed;arm64-simulatoris generated it is not possible tolipobotharm64andarm64-simulatorinto single fat binarysupport for
<arch>arm64-simulator</arch>It was required to allow
archto contain both CPU arch and environment. To achieve thisArchenum was renamed intoCpuArchandArchvalue object is introduced that combinesCpuArchandEnvironment. Code was refactored to work with new object (in future we might extend it with OS and have complete triple).combining
arm64andarm64-simulatorLipo is unable to make fat binary for binaries of same CPU arch. And apple tells to produce xcframework instead.
Changes were done to do following:
Info.plistthat describes xcframework structurerobovm.xmlhas to specify following target:eclipse plugin
can now run on m1 Mac and launch on arm64 sim
other fixes
CpuArch default arch was picked from
LLVM_HOST_TRIPLEwhich specified host where LLVM lib was compiled, not actually host it is now running on.As result it affected default arch selection for Console/Framework targets. Reworked to use
System.getProperty("os.arch")