Skip to content

Conversation

dkimitsa
Copy link
Contributor

Root case: SKStoreReviewPresentationWindow was kept in KEY_WINDOW. As result, it's dealloc wasn't called and sadly iOS15 has logic to triger code to pick another key window in SKStoreReviewPresentationWindow.dealloc.

This change might break some project that doesn't strong keep windows somewhere in AppDelegate

…eReviewController.requestReview();

Root case: SKStoreReviewPresentationWindow was kept in KEY_WINDOW. As result, it's dealloc wasn't called and sadly iOS15 has logic to triger code to pick another key window in SKStoreReviewPresentationWindow.dealloc.

This change might break some project that doesn't strong keep windows somewhere in AppDelegate
@guillerodriguez
Copy link

Root case: SKStoreReviewPresentationWindow was kept in KEY_WINDOW. As result, it's dealloc wasn't called and sadly iOS15 has logic to triger code to pick another key window in SKStoreReviewPresentationWindow.dealloc.

This change might break some project that doesn't strong keep windows somewhere in AppDelegate

Can't this be done without breaking backwards compatibility? (see comment). Perhaps with a configuration option or something?

I don't think it's good to potentially break any project just to fix those which use SKStoreReviewPresentationWindow.

@dkimitsa
Copy link
Contributor Author

@guillerodriguez I believe there is not much such project that doesn't keep window and relies on workaround I've removed.
anyway lib-gdx is not affected. in any case every release introduces some amount of breaking changes adopter have to adjust to.

@Tom-Ski Tom-Ski merged commit 3e02c91 into MobiVM:master Jan 31, 2022
@guillerodriguez
Copy link

@guillerodriguez I believe there is not much such project that doesn't keep window and relies on workaround I've removed.
anyway lib-gdx is not affected.

well, not every Robovm user is using libgdx..

in any case every release introduces some amount of breaking changes adopter have to adjust to.

Will it be at least documented somewhere?

@dkimitsa dkimitsa deleted the fix/hang_on_requestReview branch February 1, 2022 10:37
@MrStahlfelge
Copy link

Can the example project get updated accordingly?

@dkimitsa
Copy link
Contributor Author

@MrStahlfelge it was all time like this

@MrStahlfelge
Copy link

Okay, sorry! I had it different in my project and thought it was copied from the template.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants