fix for #557. merged several CryptoLib/OpenSSL fixes #564
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n file descriptor op fails (like no more failes available) destructor of AppData will try to release not initialized mutex (will cause a crash)
…/secadv/20101116-2.txt) that were causing the crash due multiple release of s->session->tlsext_ecpointformatlist due race in multithreading
…ltithreading (https://android-review.googlesource.com/c/platform/external/conscrypt/+/68360) We guard all state with a single lock "stateLock", which replaces usages of "this" and "handshakeLock". We do not perform any blocking operations while holding this lock. In particular, startHandshake is no longer synchronized. We use a single integer to keep track of handshake state instead of a pair of booleans. Also fix a bug in getSession, the previous implementation wouldn't work in cut-through mode.
2 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed crash due multithreading.
Root case:
Also merged