* fixed: @ByVal is not working for GlobalValues/Struct getters #550
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
structures are not being copied and only their pointer being marshalled (same as in case of @ByRef). This causes number of bugs:
The fix
make a copy of structure on heap as its required by @byval
Side effect of the fix
The fix breaks existing code that is built around this bug. An example is
CGRect
constructor that stops working:After the fix
getOrigin()
/getSize()
return a copy (byValue) structures. And changes to them doesn't affectCGRect
struct itself anymore.