* fixed #542: Dagger with Kotlin, IDE IPA Creation Problem #549
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Root case: `CompilerManager` is not invoking build plugins such as Dagger. As result intermediate classes are not being generated and RoboVM compilation fails. # As a fix: `ProjectTaskManager.build(module)` is now used with is equal to menu `Build/build module`. Once build is success -- RoboVM compiles IPA/Framework binaries. # other moments `RoboVmCompileTask` was removed from compilation chain. This means that it will not be triggered automatically. However IPA/Framework was reworked in this fix to call it manually. Also run configuration already has manual RoboVM compilation invocation as pre-launch task # other fixes - better cancellation processing during IPA/Framework compilation - fixed issue during SDK files installation during first launch
…ce in Compiler thread
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixed #542 and also changes the way project compilation is triggered (for IPA/Framework creation)
Root case:
CompilerManageris not invoking build plugins such as Dagger. As result intermediate classes are not being generated and RoboVM compilation fails.As a fix:
ProjectTaskManager.build(module)is now used with is equal to menuBuild/build module. Once build is success -- RoboVM compiles IPA/Framework binaries.other moments
RoboVmCompileTaskwas removed from compilation chain. This means that it will not be triggered automatically. However IPA/Framework was reworked in this fix to call it manually. Also run configuration already has manual RoboVM compilation invocation as pre-launch taskother fixes