ios13_postfix#8: fix for missing objc parent classes (parent younger than child case) #442
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… able to update parent version number
…ho plugin is not able update parent's version during release
…pdate it gradle version
…ncies. otherview version:commit failed to pick up non existing dependencies (for future version)
…ion of iOS than child. before the fix it fails with ObjCClassNotFoundException when running on iOS where parent class is not present.
dkimitsa
added a commit
to dkimitsa/robovm
that referenced
this pull request
Apr 9, 2020
…than child case) (MobiVM#442) * * jetbrains intellij plugin for gradle version updated * * intellij maven pom reworked into stand-alone. as mvn:version is not able to update parent version number * * added sonatype repo for snapshot dependencies * * eclipse plugin's maven.pom switched into standalone (without) as tyho plugin is not able update parent's version during release * * release script reworked to properly pick up new idea artifact and update it gradle version * * Idea: release script updated to use property to specify the dependencies. otherview version:commit failed to pick up non existing dependencies (for future version) * * added handling of situation, when parent class is using higher version of iOS than child. before the fix it fails with ObjCClassNotFoundException when running on iOS where parent class is not present. * * comments + few cleanups
dkimitsa
added a commit
to dkimitsa/robovm
that referenced
this pull request
Apr 9, 2020
…than child case) (MobiVM#442) * * jetbrains intellij plugin for gradle version updated * * intellij maven pom reworked into stand-alone. as mvn:version is not able to update parent version number * * added sonatype repo for snapshot dependencies * * eclipse plugin's maven.pom switched into standalone (without) as tyho plugin is not able update parent's version during release * * release script reworked to properly pick up new idea artifact and update it gradle version * * Idea: release script updated to use property to specify the dependencies. otherview version:commit failed to pick up non existing dependencies (for future version) * * added handling of situation, when parent class is using higher version of iOS than child. before the fix it fails with ObjCClassNotFoundException when running on iOS where parent class is not present. * * comments + few cleanups
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR workaround case when child classes inherit parent that is younger. This causes
ObjCClassNotFoundExceptionwhen running code iOS version where parent is not available but child is available (and expect to work). Bright example isGKPlayer:the fix -- is allow to have missing classes as parent but don't allow instantiating of them.