ios13_postfix#3: compiler, adding support for @Block struct member types #421
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on when compiling CMBufferHandlers: >java.lang.IllegalArgumentException: No @marshaler found for return type of @StructMember method <org.robovm.apple.coremedia.CMBufferHandlers: org.robovm.objc.block.Block1 getGetDecodeTimeStamp()> > at org.robovm.compiler.MarshalerLookup.findMarshalerMethod(MarshalerLookup.java:169)
dkimitsa
added a commit
to dkimitsa/robovm
that referenced
this pull request
Apr 9, 2020
…on when compiling CMBufferHandlers: (MobiVM#421) >java.lang.IllegalArgumentException: No @marshaler found for return type of @StructMember method <org.robovm.apple.coremedia.CMBufferHandlers: org.robovm.objc.block.Block1 getGetDecodeTimeStamp()> > at org.robovm.compiler.MarshalerLookup.findMarshalerMethod(MarshalerLookup.java:169)
dkimitsa
added a commit
to dkimitsa/robovm
that referenced
this pull request
Apr 9, 2020
…on when compiling CMBufferHandlers: (MobiVM#421) >java.lang.IllegalArgumentException: No @marshaler found for return type of @StructMember method <org.robovm.apple.coremedia.CMBufferHandlers: org.robovm.objc.block.Block1 getGetDecodeTimeStamp()> > at org.robovm.compiler.MarshalerLookup.findMarshalerMethod(MarshalerLookup.java:169)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds support for blocks in structures. this fixes following exception when compiling CMBufferHandlers:
In details there are several moments and fixes:
@Blockaffected methods are generated byObjCBlockPlugininObjCBlockPlugin.Beforeclass run. The problem here is thatClassCompilerinvokes it afterStructMemberMethodCompiler.resetwhere this marshaller is required (and where exception is happening). The fix is to move reset section of method compilers below invocation of pluginsBefore. This makes marshallers generated at momentStructMemberMethodCompiler.resetneeds it.ObjCBlockPlugin.Beforewas not considering @StructMember annotated methods as subject for method transformation and the fix is trivial -- extending condition to include the case.