Skip to content

Unbreak m.trust #2516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 17, 2019
Merged

Unbreak m.trust #2516

merged 4 commits into from
Aug 17, 2019

Conversation

dead-claudia
Copy link
Member

@dead-claudia dead-claudia commented Aug 17, 2019 •
edited
Loading

Description

  • Fix double-rendering of trusted content within contenteditable elements
  • Fix error on m.trust updating

Motivation and Context

Fixes #2502
Fixes #2498

How Has This Been Tested?

Added new tests for each and verified each failed without the appropriate fix.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation change

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated docs/change-log.md

@dead-claudia
Actually return the check from maybeSetContentEditable
cc72163 
Lots of code paths relied on it being a boolean. When I created the
abstraction, I apparently forgot to make sure it returned the result.
@dead-claudia
Don't forget to copy instance state over
602e845
@dead-claudia
Update changelog [skip ci]
57698cc
@dead-claudia
Fix changelog issue [skip ci]
cc47788
@dead-claudia dead-claudia merged commit 30ad45c into MithrilJS:next Aug 17, 2019
@dead-claudia dead-claudia deleted the unbreak-m-trust branch August 17, 2019 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
Triage/bugs
Status: Closed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Contenteditable node renders the content twice Mithril throws an error when two or more sibling components render content via m.trust
1 participant
@dead-claudia