Add a CircleCI e2e job based on Debian image #870
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukaszo
approved these changes
Mar 5, 2019
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 1 approvals obtained (waiting on @ivan4th)
pkg/metadata/types/annotations.go, line 124 at r1 (raw file):
SystemUUID *uuid.UUID // ForceDHCPNetworkConfig prevents Virtlet from using Cloud-Init based network // configuration and makes it only provide DHCP. Note that this is will
remove is
53da665 to
042367c
Compare
ivan4th
commented
Mar 5, 2019
There was a problem hiding this comment.
Reviewable status:
pkg/metadata/types/annotations.go, line 124 at r1 (raw file):
Previously, lukaszo (Łukasz Oleś) wrote…
remove
is
Done.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes Virtlet and its e2e tests that run on CircleCI compatible with Debian OpenStack images, adds a e2e CircleCI job that uses Debian images, and unblocks the CI by temporarily disabling the multi CNI job.
This change is