Update k8s example #840
Merged
Update k8s example #840
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jellonek
suggested changes
Jan 7, 2019
There was a problem hiding this comment.
Reviewable status: 0 of 1 approvals obtained (waiting on @lukaszo)
examples/k8s.yaml, line 34 at r1 (raw file):
# set root volume size VirtletRootVolumeSize: 4Gi VirtletVCPUCount: "2"
What is that needed for? Is there any specific requirement for that?
jellonek
approved these changes
Jan 7, 2019
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status: 1 change requests, 0 of 1 approvals obtained
examples/k8s.yaml, line 34 at r1 (raw file):
Previously, jellonek (Piotr Skamruk) wrote…
What is that needed for? Is there any specific requirement for that?
Ok. It's because of changed kubeadm requirement. Get it ;)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is