Keep VM data during node restart #839
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please use |
|
@jellonek how can I rerun the test jobs? |
|
@jellonek all e2e reported error: could you please take a look why? |
|
Looks like there is an issue in master after merging #837 so it's disconnected with your changes. |
jellonek
approved these changes
Jan 8, 2019
There was a problem hiding this comment.
Reviewed 9 of 9 files at r1.
Reviewable status: 0 of 1 approvals obtained
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found during node restart, all VM data are deleted during GC. From my point of view, VM is different from Pod, the data should be kept, and virtlet keeps VM data during virtlet pod restart, kubelet restart, but always deleting VM data after node reboot. The virtlet GC is too aggressive, as during node reboot the
IsPathAnNsalways returns false, all sandboxes and containers are deleted from db. This pr only updated sandbox status, and make the /etc/libvirt/qemu be a host mount which makes sure libvirt can find the domain after node reboot.This change is