Use minimal libguestfs bindings #837
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 28, 2018 21:44
Also, add a test for diskimage
c6da649 to
25bcaa4
Compare
pigmej
reviewed
Jan 2, 2019
There was a problem hiding this comment.
Technically looks ok for me. But let's allow others to check more deeply.
Reviewable status: 0 of 1 approvals obtained (waiting on @jellonek)
jellonek
suggested changes
Jan 3, 2019
There was a problem hiding this comment.
Reviewed 29 of 29 files at r1.
Reviewable status: 0 of 1 approvals obtained (waiting on @ivan4th and @jellonek)
pkg/diskimage/diskimage_test.go, line 2 at r1 (raw file):
/* Copyright 2016 Mirantis
2018 or 2019?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #822
This PR also adds some tests for injecting the files into rootfs, but more tests still needed there (configmap processing should be verified using fake k8s client)
This change is