Make mac checking case insensitive #795
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukaszo
suggested changes
Nov 6, 2018
There was a problem hiding this comment.
Reviewable status: 0 of 2 approvals obtained (waiting on @jellonek)
pkg/libvirttools/cloudinit.go, line 407 at r1 (raw file):
func mtuForMacAddress(mac string, ifaces []*network.InterfaceDescription) (uint16, error) { for _, iface := range ifaces { if iface.HardwareAddr.String() == strings.ToLower(mac) {
what about left part?
jellonek
commented
Nov 6, 2018
There was a problem hiding this comment.
Reviewable status: 1 change requests, 0 of 2 approvals obtained (waiting on @lukaszo)
pkg/libvirttools/cloudinit.go, line 407 at r1 (raw file):
Previously, lukaszo (Łukasz Oleś) wrote…
what about left part?
It's made from https://golang.org/src/net/mac.go?s=190:208#L1 so imo we should expect from stdlib that as stable behavior.
lukaszo
approved these changes
Nov 6, 2018
There was a problem hiding this comment.
Reviewable status: 1 change requests, 0 of 2 approvals obtained
ivan4th
approved these changes
Nov 6, 2018
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1.
Reviewable status: 1 of 2 approvals obtained
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #794
This change is