Reviewable status: 0 of 2 approvals obtained (waiting on @jellonek)

pkg/utils/strings.go, line 41 at r1 (raw file):

// Stringify returns string representation for provided value.
func Stringify(value interface{}) (string, error) {

Perhaps can just use fmt.Sprintf("%v", value) instead?

pkg/utils/cgroups/controllers.go, line 36 at r1 (raw file):

// GetProcessControllers returns mapping between controller types and theirs
// paths inside cgroups fs mount for particular process identificator

Returns the mapping between controller types and their paths inside cgroup fs for the specified PID

pkg/utils/cgroups/controllers.go, line 76 at r1 (raw file):

}

// Controller represents named controller for particular process

Controller represents a named controller for a process

pkg/utils/cgroups/controllers.go, line 82 at r1 (raw file):

}

// GetProcessController returns named resource Controller for given process identificator

returns a named resource controller for the specified PID

pkg/utils/cgroups/controllers.go, line 105 at r1 (raw file):

}

// Set sets value for particular setting using this controller

Set sets the value of a controller setting

Reviewable status: 1 change requests, 0 of 2 approvals obtained (waiting on @jellonek and @ivan4th)

pkg/utils/strings.go, line 41 at r1 (raw file):

That would succeed always. With my version you have additional validation if correct type was passed.
Maybe in fact simpler version would be better as this check is done on runtime, not on compile time. WDYT?

pkg/utils/cgroups/controllers.go, line 36 at r1 (raw file):

Done.

pkg/utils/cgroups/controllers.go, line 76 at r1 (raw file):

Done.

pkg/utils/cgroups/controllers.go, line 82 at r1 (raw file):

Done.

pkg/utils/cgroups/controllers.go, line 105 at r1 (raw file):

Done.

Reviewable status: 1 change requests, 0 of 2 approvals obtained (waiting on @jellonek)

pkg/utils/strings.go, line 41 at r1 (raw file):

In this case neither the func name (which is quite important) nor its description tells about what value type is expected. I'd go with plain fmt.Sprintf(). If this func needs to be kept (it still needs another name, like StringifySomeKindOfValue), it still can be done via fmt.Sprintf() with some kind of type check in place.

BTW, the current impl checks the type during runtime. You can only do compile-time checking by making several funcs for different types (as there's no func overloading in Go)

Reviewable status: 1 change requests, 0 of 2 approvals obtained (waiting on @ivan4th)

pkg/utils/strings.go, line 41 at r1 (raw file):

I understand that it's done on runtime (it's in second part of my comment).
Ok, changed that to simple fmt.Sprintf without type checking as lack of stringer interface implementation on particular interface simply should not occur.

Reviewed 4 of 6 files at r1, 2 of 2 files at r2.
Reviewable status: 1 change requests, 0 of 2 approvals obtained (waiting on @ivan4th)

Reviewable status: 1 of 2 approvals obtained