Skip to content

Conversation

ivan4th
Copy link
Contributor

@ivan4th ivan4th commented Aug 27, 2018

  • basic block PV support
  • symlinks for the devices
  • mounting the devices inside the VM
  • fix shell escaping
  • update examples
  • update docs

This change is Reviewable

Ivan Shvedunov added 4 commits September 3, 2018 12:07
The user can use `mounts` in cloud-init userdata
to mount the volumes, but there's one problem.
The symlink script that ensures that the "container"
device paths lead to the actual block devices corresponding
to the PVs runs after cloud-init mounts are handled.
Thus, we need to update cloud-init mounts, replacing
the references to PV block devices with `/dev/disk/by-path/...`
Ivan Shvedunov added 2 commits September 3, 2018 17:02
Right now it doesn't actually change anything but may help avoid bugs if
the mount script will be updated to contain userdata mounts at some
point in future.
@ivan4th ivan4th changed the title [WiP] Add support for block PVs Add support for block PVs Sep 3, 2018
Copy link
Contributor

@pigmej pigmej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 51 of 51 files at r1.
Reviewable status: 0 of 2 approvals obtained

Copy link
Contributor

@lukaszo lukaszo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 1 of 2 approvals obtained

@ivan4th ivan4th merged commit 85d3107 into master Sep 5, 2018
@ivan4th ivan4th deleted the ivan4th/block-pv branch September 5, 2018 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants