Skip to content

Improve error handling in annotations loader #713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 11, 2018
Merged

Improve error handling in annotations loader #713

merged 1 commit into from
Jul 11, 2018

Conversation

jellonek
Copy link
Contributor

@jellonek jellonek commented Jul 10, 2018 •
edited by pigmej
Loading

This change is Reviewable

@jellonek jellonek mentioned this pull request Jul 10, 2018
Merged
pigmej
pigmej approved these changes Jul 11, 2018
View reviewed changes
Copy link
Contributor

@pigmej pigmej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1.
Reviewable status: 0 of 2 LGTMs obtained

pigmej
pigmej approved these changes Jul 11, 2018
View reviewed changes
Copy link
Contributor

@pigmej pigmej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: 0 of 2 LGTMs obtained, and 1 stale

pigmej
pigmej approved these changes Jul 11, 2018
View reviewed changes
Copy link
Contributor

@pigmej pigmej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: 1 of 2 LGTMs obtained

ivan4th
ivan4th approved these changes Jul 11, 2018
View reviewed changes
Copy link
Contributor

@ivan4th ivan4th left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: 1 of 2 LGTMs obtained, and 1 stale

@ivan4th ivan4th merged commit 69ff207 into master Jul 11, 2018
@ivan4th ivan4th deleted the jell/annot branch July 11, 2018 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
2 more reviewers

@ivan4th ivan4th ivan4th approved these changes

@pigmej pigmej pigmej approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jellonek @ivan4th @pigmej