Fix release CI and e2e runner #459
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Xinfeng Liu <XinfengLiu@icloud.com>
There was a problem hiding this comment.
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (4)
.github/workflows/e2e.yml:8
- Changing the OS version to ubuntu-22.04 may lead to differences in environment behavior. Verify that all workflow steps are compatible with this new image.
runs-on: ubuntu-22.04
.github/workflows/docs.yml:63
- Upgrading to actions/upload-pages-artifact@v3 may introduce breaking changes. Please check the action's changelog to ensure its behavior meets the workflow requirements.
uses: actions/upload-pages-artifact@v3
.github/workflows/docs.yml:76
- The update to actions/deploy-pages@v4 could affect the deployment process. It is recommended to review the updated version's documentation for any changes that may impact functionality.
uses: actions/deploy-pages@v4
.github/workflows/Release.yml:6
- The addition of the workflow_dispatch trigger and explicit permissions should be reviewed to ensure they align with security best practices and the intended release process.
workflow_dispatch:
nwneisen
approved these changes
Apr 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes release CI job errors
Proposed Changes
Cherry-pick #457 and #458