Skip to content

Add struct for unimplemented methods #294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 4, 2024
Merged

Add struct for unimplemented methods #294

merged 1 commit into from
Jan 4, 2024

Conversation

nwneisen
Copy link
Contributor

@nwneisen nwneisen commented Jan 4, 2024

Fixes #293

Proposed Changes

Add the UnimplementedServer structure to the service which adds unimplemented methods with the correct message until they are implmented.

Output after making this change

docker@minikube:~$ crictl statsp
E0104 17:03:32.245511    5810 remote_runtime.go:1148] "ListPodSandboxStats with filter from runtime service failed" err="rpc error: code = Unimplemented desc = method ListPodSandboxStats not implemented" filter="&PodSandboxStatsFilter{Id:,LabelSelector:map[string]string{},}"
FATA[0000] get pod stats: display pod stats: list pod sandbox stats: rpc error: code = Unimplemented desc = method ListPodSandboxStats not implemented

@nwneisen nwneisen merged commit 77b8604 into Mirantis:master Jan 4, 2024
@nwneisen nwneisen deleted the 293-return-unimplemented branch January 21, 2025 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@afbjorklund afbjorklund afbjorklund approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ListPodSandboxStats returns error
2 participants
@nwneisen @afbjorklund