Skip to content

make the launch.json generation leaner #618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 28, 2018
Merged

make the launch.json generation leaner #618

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
795e142
make the launch.json generation leaner
isidorn Nov 13, 2018
5189547
Use async
isidorn Nov 15, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 7 additions & 13 deletions configureWorkspace/configDebugProvider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,23 +6,17 @@
'use strict';

import * as vscode from 'vscode';
export class DockerDebugConfigProvider implements vscode.DebugConfigurationProvider {
import { ext } from '../extensionVariables';

public provideDebugConfigurations(folder: vscode.WorkspaceFolder | undefined, token?: vscode.CancellationToken): vscode.ProviderResult<vscode.DebugConfiguration[]> {
export class DockerDebugConfigProvider implements vscode.DebugConfigurationProvider {

const config: vscode.DebugConfiguration = {
public async provideDebugConfigurations(folder: vscode.WorkspaceFolder | undefined, token?: vscode.CancellationToken): Promise<vscode.DebugConfiguration[]> {
const remoteRoot = await ext.ui.showInputBox({ value: '/usr/src/app', prompt: 'Please enter your Docker remote root' });
return [{
name: 'Docker: Attach to Node',
type: 'node',
request: 'attach',
port: 9229,
address: 'localhost',
localRoot: '\${workspaceFolder}',
remoteRoot: '/usr/src/app',
protocol: 'inspector'
};

return [config];

remoteRoot
}];
}

}
6 changes: 1 addition & 5 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -287,11 +287,7 @@
"type": "node",
"request": "attach",
"name": "Docker: Attach to Node",
"port": 9229,
"address": "localhost",
"localRoot": "^\"\\${workspaceFolder}\"",
"remoteRoot": "/usr/src/app",
"protocol": "inspector"
"remoteRoot": "/usr/src/app"
}
}
]
Expand Down