Skip to content

Conversation

martinpucik
Copy link
Contributor

What does this implement/fix? Explain your changes.

  • Adds an option to use MessagesLayoutDelegate methods for adjusting message top/bottom label alignments without the need to subclass MessageSizeCalculators
  • Chat example not used files cleanup

Does this close any currently open issues?

N/A

@martinpucik martinpucik self-assigned this Feb 3, 2022
@martinpucik martinpucik removed their assignment Feb 3, 2022
…gnments

Fix example MessageKit local package import
Copy link
Member

@Kaspik Kaspik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know it will be small but could you please create super small V4 Migration info section into Readme file for people that upgrade from V3?

@martinpucik
Copy link
Contributor Author

There are no breaking changes yet in 4.0. I'd add the migration doc when there is something to migrate 😁

@Kaspik
Copy link
Member

Kaspik commented Feb 3, 2022

Well you have to add new functions when upgrading to it, they are not optional, right? 😅

@martinpucik
Copy link
Contributor Author

There are default implementations in MessagesLayoutDelegate extension so clients don't have to add them 🙌

@martinpucik martinpucik merged commit c2cf1a2 into master Feb 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants