Bug Fix: mbedtls_ecdsa_verify_restartable fails with ECDSA_SIGN_ALT #7499
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please add a signoff line to your commit message(s), otherwise we can't accept them. The DCO check needs to pass. |
|
Out of curiosity, which ATECC608 integration are you referring to? I don't recall seeing one that uses |
4bcec0e to
b8661ba
Compare
|
DCO finished! I discovered this issue when attempting to use cryptoauthlib with mbedTLS 3 (upgrading from 2). ALT verify never would work with my ATECC608, so I always had it disabled. Non ALT verify worked with mbedTLS 2 because |
gilles-peskine-arm
requested changes
Apr 26, 2023
When ECDSA_SIGN_ALT but not ECDSA_VERIFY_ALT, mbedtls_ecdsa_can_do was not being defined causing mbedtls_ecdsa_verify_restartable to always fail Signed-off-by: JonathanWitthoeft <jonw@gridconnect.com>
Signed-off-by: JonathanWitthoeft <jonw@gridconnect.com>
52bb7b3 to
9b26518
Compare
9eb233a to
21ab6c2
Compare
Signed-off-by: JonathanWitthoeft <jonw@gridconnect.com>
21ab6c2 to
2a878a8
Compare
gilles-peskine-arm
approved these changes
Apr 27, 2023
3 tasks
tom-daubney-arm
approved these changes
Apr 28, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When ECDSA_SIGN_ALT but not ECDSA_VERIFY_ALT, mbedtls_ecdsa_can_do was not being defined causing mbedtls_ecdsa_verify_restartable to always fail
closes #7498
Description
This will support ATECC608 integration for signing but not verification.
Gatekeeper checklist
Notes for the submitter
Please refer to the contributing guidelines, especially the
checklist for PR contributors.