Skip to content

Marusyk/grok.net#18 custom pattern validation #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Sep 4, 2021
Merged

Marusyk/grok.net#18 custom pattern validation #23

merged 8 commits into from
Sep 4, 2021

Conversation

GioMaz
Copy link
Contributor

@GioMaz GioMaz commented Aug 22, 2021

This checks if the line in the file is divided by a space

@Marusyk Marusyk self-requested a review August 24, 2021 21:59
@Marusyk Marusyk self-assigned this Aug 24, 2021
@Marusyk Marusyk linked an issue Aug 24, 2021 that may be closed by this pull request
Add validation of custom grok patterns file #18
Closed
@Marusyk
Copy link
Owner

Marusyk commented Aug 24, 2021

Please add unit tests

Marusyk
Marusyk reviewed Aug 27, 2021
View reviewed changes
Copy link
Owner

@Marusyk Marusyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about throwing some valid exception when the custom file is not valid instead of just ignore it?

@GioMaz
Copy link
Contributor Author

GioMaz commented Aug 27, 2021

What do you think about throwing some valid exception when the custom file is not valid instead of just ignore it?

Sure

Marusyk
Marusyk requested changes Aug 30, 2021
View reviewed changes
Marusyk
Marusyk approved these changes Sep 4, 2021
View reviewed changes
Copy link
Owner

@Marusyk Marusyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM
Many thanks for your contribution.
Sorry for the delay (just vacation time 😉)

@Marusyk Marusyk merged commit e26b539 into Marusyk:main Sep 4, 2021
@Marusyk Marusyk mentioned this pull request Sep 4, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Marusyk Marusyk Marusyk approved these changes

Assignees

@Marusyk Marusyk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add validation of custom grok patterns file
2 participants
@GioMaz @Marusyk