Skip to content

Created basic xUnit tests #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Oct 18, 2019
Merged

Created basic xUnit tests #6

merged 9 commits into from
Oct 18, 2019

Conversation

Justin-Lloyd
Copy link
Contributor

@Justin-Lloyd Justin-Lloyd commented Oct 16, 2019 •
edited by Marusyk
Loading

I noticed there seemed to be no progress on this issue so I created a few xUnit tests, hope that's ok.
I'll look to create some more over the next few days.

Issue #1

@Marusyk Marusyk added Hacktoberfest enhancement New feature or request labels Oct 16, 2019
@Marusyk Marusyk self-assigned this Oct 16, 2019
Marusyk
Marusyk requested changes Oct 16, 2019
View reviewed changes
Copy link
Owner

@Marusyk Marusyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution. We need more tests that cover more cases. I think it should be at least 10 test that cover really meaningful cases

@Justin-Lloyd
Copy link
Contributor Author

Thank you for your contribution. We need more tests that cover more cases. I think it should be at least 10 test that cover really meaningful cases

Happy to get involved!

Marusyk
Marusyk approved these changes Oct 18, 2019
View reviewed changes
Copy link
Owner

@Marusyk Marusyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Marusyk Marusyk merged commit 9383ff3 into Marusyk:master Oct 18, 2019
@Marusyk
Copy link
Owner

Marusyk commented Oct 18, 2019

@Justin-Lloyd your changes have been merged, thanks for your contribution 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Marusyk Marusyk Marusyk approved these changes

Assignees

@Marusyk Marusyk

Labels
enhancement New feature or request Hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Justin-Lloyd @Marusyk