Skip to content

Conversation

FarzamMohammadi
Copy link
Contributor

No description provided.

@FarzamMohammadi FarzamMohammadi force-pushed the feat/add-editorconfig-action branch from f9c0a40 to 99ec1a0 Compare July 6, 2022 19:03
@FarzamMohammadi FarzamMohammadi requested a review from Marusyk July 6, 2022 19:04
@FarzamMohammadi FarzamMohammadi force-pushed the feat/add-editorconfig-action branch from 99ec1a0 to 913e8e9 Compare July 6, 2022 19:05
@FarzamMohammadi FarzamMohammadi changed the title Update workflows w/ EditorConfig-Action Update workflow w/ EditorConfig-Action Jul 6, 2022
Copy link
Owner

@Marusyk Marusyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
Thank you for your contribution

Could you show the screens with successfully passed workflow before merge?

@FarzamMohammadi FarzamMohammadi force-pushed the feat/add-editorconfig-action branch from 913e8e9 to c666498 Compare July 7, 2022 18:50
@FarzamMohammadi FarzamMohammadi requested a review from Marusyk July 7, 2022 18:54
Copy link
Owner

@Marusyk Marusyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you show the screens with successfully passed workflow before merge?

@FarzamMohammadi FarzamMohammadi force-pushed the feat/add-editorconfig-action branch 8 times, most recently from a889590 to 0351ea1 Compare July 11, 2022 20:59
@FarzamMohammadi
Copy link
Contributor Author

Seems like regardless of the changes I make I end up facing this error. Any suggestions?
image

Copy link
Owner

@Marusyk Marusyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unfortunately I have no idea

@FarzamMohammadi FarzamMohammadi force-pushed the feat/add-editorconfig-action branch 6 times, most recently from 00ff54a to c0eba10 Compare July 12, 2022 20:43
@FarzamMohammadi FarzamMohammadi force-pushed the feat/add-editorconfig-action branch from c0eba10 to 190e16c Compare July 12, 2022 20:52
@FarzamMohammadi
Copy link
Contributor Author

I tried most of the solutions mentioned on the web, still no luck. I'm pretty sure this is an issue that needs to be fixed within EditorConfig-Action. I saw that you created an issue under the action repo. I'll keep an eye out on it and once there is a solution I'll update the PR.

@Marusyk Marusyk merged commit f56312b into Marusyk:main Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants