-
Notifications
You must be signed in to change notification settings - Fork 57
Add CI/CD for PowerShell module #49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution.
I would prefer to transform the Publish step to the build.cake. It will allow us to Publish even from a local machine.
The main idea of the Cake - keep all related things only in the cake. It will be very easy to move from GitHub Actions to Azure DevOps for example.
* fix macos build * prevent cake importing a lot of packages in powershell unrelated tasks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make it a part of build.cake file
split powershell task to pack and push tasks
Requested changes made. MacOS build is failing at the moment. Shall we abandon it for now? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 LGTM, thank you @moeddami
We'll fix MacOS build later
See #47
Next steps, create an API key for the PowerShell gallery and add a new secret for it called
PS_NUGET_API_KEY
.