Skip to content

Conversation

eddami
Copy link
Contributor

@eddami eddami commented Jan 4, 2022

See #47
Next steps, create an API key for the PowerShell gallery and add a new secret for it called PS_NUGET_API_KEY.

Copy link
Owner

@Marusyk Marusyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution.
I would prefer to transform the Publish step to the build.cake. It will allow us to Publish even from a local machine.

The main idea of the Cake - keep all related things only in the cake. It will be very easy to move from GitHub Actions to Azure DevOps for example.

eddami added 2 commits January 6, 2022 01:32
* fix macos build
* prevent cake importing a lot of packages in powershell unrelated tasks
Copy link
Owner

@Marusyk Marusyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make it a part of build.cake file

@eddami
Copy link
Contributor Author

eddami commented Jan 8, 2022

Requested changes made. MacOS build is failing at the moment. Shall we abandon it for now?

@eddami eddami requested a review from Marusyk January 8, 2022 22:25
Copy link
Owner

@Marusyk Marusyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM, thank you @moeddami
We'll fix MacOS build later

@Marusyk Marusyk merged commit bbac838 into Marusyk:main Jan 8, 2022
@Marusyk Marusyk linked an issue Jan 8, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add CI/CD for PowerShell module
2 participants