Skip to content

Follow up for issue github coverage badge creation #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 13, 2021

Conversation

Adityanr
Copy link
Contributor

Follow up for issue #30

I have added the following changes:

  • Replaced Opencover cake with coverlet generating opencover format report. Opencover is not so reliable for dotnet core.
  • Checkout depth changed to 0 in windows workflow for coveralls to fetch commit history.
  • Added step to fetch environment variable COVERALLS_REPO_TOKEN from github secrets.

Managed to modify workflows from github directly instead of my local system

Please create a secret named COVERALLS_REPO_TOKEN containing repository token fetched from coveralls.io before merging PR.

Please find attached the successful github actions build: https://github.com/Adityanr/grok.net/actions/runs/1339133656
Please review this PR @Marusyk
coverage_generation
coverlet_test_run

Final coverage report within coveralls: https://coveralls.io/github/Adityanr/grok.net?branch=workflow-opencover-issue

@Marusyk Marusyk added bug Something isn't working Hacktoberfest labels Oct 13, 2021
@Marusyk Marusyk linked an issue Oct 13, 2021 that may be closed by this pull request
@Marusyk Marusyk merged commit ab781e6 into Marusyk:main Oct 13, 2021
@Marusyk
Copy link
Owner

Marusyk commented Oct 13, 2021

@Adityanr it works
Thank you very much for your effort.
Really appreciate it, thanks

@Adityanr
Copy link
Contributor Author

Just happy it worked :) @Marusyk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generate code coverage badge
2 participants