Skip to content

Add chunk function to split array into smaller #265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 10, 2020
Merged

Add chunk function to split array into smaller #265

merged 1 commit into from
Dec 10, 2020

Conversation

karelbilek
Copy link
Contributor

@karelbilek karelbilek commented Oct 26, 2020 •
edited
Loading

this was a function that I found helpful to have.

I tried to follow your style.

@technosophos
Copy link
Member

Should the order of arguments be reversed? One of the things we've tried to do is make it easier to pipe data from one command to the next. Doing tuple 1 2 3 4 5 | chunk 3 feels a little more ergonomic than using a variable in between.

@karelbilek
Copy link
Contributor Author

Oh sure. I rarely use piping and use vars instead so I forgot about this usecase.

@karelbilek
Copy link
Contributor Author

changed, rebased

technosophos
technosophos approved these changes Dec 10, 2020
View reviewed changes
Copy link
Member

@technosophos technosophos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you.

@mattfarina mattfarina merged commit 364146e into Masterminds:master Dec 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@technosophos technosophos technosophos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@karelbilek @technosophos @mattfarina