Fix issue where error does not propogate #953
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -20,6 +20,10 @@ func StripVendor() error { | |||
| } | |||
|
|
|||
| err := filepath.Walk(searchPath, func(path string, info os.FileInfo, err error) error { | |||
| if err != nil { | |||
There was a problem hiding this comment.
Adding these lines causes an issue for me now when trying to run glide install --strip-vendor
The error it produces is similar to:
[INFO] Replacing existing vendor dependencies
[INFO] Removing nested vendor and Godeps/_workspace directories...
[INFO] Removing: <SOME_PATH>/lib/go/vendor
[ERROR] Unable to strip vendor directories: open <SOME_PATH>/lib/go/vendor: no such file or directory
Do I need to create an Issue on this? It's causing our builds to fail now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.