Skip to content

Issue 955 #956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 14, 2017
Merged

Issue 955 #956

merged 3 commits into from
Dec 14, 2017

Conversation

apynes2
Copy link
Contributor

@apynes2 apynes2 commented Dec 13, 2017 •
edited
Loading

Fix for #955

  • Refactor to allow testing of the walk function
  • Tests for walk function
  • Return 'filepath.SkipDir' when removing a directory tree under the path as docs recommend
  • Cleaning up some logic in walk function
  • added integration tests that reproduce the problem

Anthony Pynes and others added 3 commits December 13, 2017 14:05
ISSUE-955 Fix "Error handling nested vendor folders"
3e5e5b9 
- Refactor to allow testing of the walk function
- Tests for walk function
- Return 'filepath.SkipDir' when removing a directory tree under the path as docs recommend
- Cleaning up some logic in walk function
ISSUE-955: added integration tests that reproduce the problem
87bb0fb
removed the go1.9 dependency
07c3b6e
@mattfarina
Copy link
Member

Thanks for the PR. Reviewing now.

@mattfarina mattfarina merged commit 3e13fd1 into Masterminds:master Dec 14, 2017
@anthonyheidenreich anthonyheidenreich deleted the ISSUE-955 branch December 14, 2017 15:31
@nixpanic nixpanic mentioned this pull request May 17, 2018
Closed
@danwinship danwinship mentioned this pull request Jul 10, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@apynes2 @mattfarina