Fix ok button not updating when file selected #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a call to _update_ok_button when files are selected. It appears that the line edit text changed signal was not detecting the changes to the path edit or name edit nodes text vales. As such _update_ok_button was not getting called when expected leading to the ok button being disabled when a valid path is inputted. Adding a call to _update_ok_button when a file is selected means it will check if confirmation should be allowed when expected.
|
Thanks!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a call to _update_ok_button when files are selected.
It appears that the line edit text changed signal is not detecting the changes to the path edit or name edit nodes text values via code. As such _update_ok_button was not getting called when expected leading to the ok button being disabled when a valid path is inputted.
Adding a call to _update_ok_button when a file is selected means it will check if confirmation should be allowed when expected.
Fixes #25