Add support for downloads from GitHub #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cool!! Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a setting to allow Godots to download releases from Github whenever possible (stable releases newer than 3.1.1 and the version 2.1.6). If the download fails, Godots will fallback to TuxFamily.
The setting can be enabled in the remote editors tab, by toggling the checkbox on the right that says «Use Github».
I had considered adding an
OptionButtonto eachTreeItemfor a release's zip, to allow the user to explicitly choose the mirror to use when downloading (as was done in https://gitlab.com/jwestman/hourglass/-/merge_requests/43), but that was not possible, since aTreeItemonly allows for normal buttons to be added.