Skip to content

Conversation

georgesnow
Copy link
Contributor

@georgesnow georgesnow commented Nov 5, 2019

@mstarke added the functionality where the database can lock when the screen goes to sleep. My Mac never sleeps nor does it log out (or at least rarely)....haha, but I use the lock screen which after 30 seconds puts my displays to sleep. anyway bugged me that my database wasn't locking. I had few instance where I got couple of bad merges of databases when I went to sue other machines. And this would fix that.

also the constraints on the preferences window need to be set. I couldn't figure out how to do it...sorry

@georgesnow georgesnow changed the title Add Lock database on Screen lock Add Lock database on Screen Sleep Nov 5, 2019
@georgesnow
Copy link
Contributor Author

@mstarke fixed.

@georgesnow
Copy link
Contributor Author

@mstarke hey just wondering - other than the constraints on the preference page (which I might take another stab at). is there anything keeping this pull request from being merged?

@georgesnow
Copy link
Contributor Author

I ask cause I would like to get in the next continuous build since that tends to be my “everyday” version of Macpass

@georgesnow
Copy link
Contributor Author

@mstarke so this should be all good including constraints to merge. I added the proper constraints as well as fixing a label error I hadn't noticed. can we go ahead now and merge this pull request?

@mstarke mstarke merged commit 9ba9024 into MacPass:master Dec 17, 2019
@mstarke
Copy link
Member

mstarke commented Dec 17, 2019

I've merged but I need to clean up the fonts. I have no clue why you changed them to something non-default

@georgesnow
Copy link
Contributor Author

@mstarke I did not intend to. I literally just cloned the repo and added the code. Then copied one of the other check boxes to make sure I didn't change any fonts etc...sorry

@mstarke
Copy link
Member

mstarke commented Dec 17, 2019

I thought that's what you did but I wasn't able to get the same results. There where multiple inconsistencies in the font settings which I suspect are there because of migrating the codebase along the way. Some other issues with the outlet not being connected properly existed as well which are all fixed now so the feature works in master. Continuous will get updated as well shortly.

@georgesnow
Copy link
Contributor Author

georgesnow commented Dec 17, 2019

@mstarke awesome thanks! i must have merge improperly from the main fork or my Xcode settings. sorry I was trying to fix the pieces I had left undone. this experience makes me nervous when I attempt to merge Touch ID code that there are going to be a ton of inconsistencies. I will need to resolve them.

@mstarke
Copy link
Member

mstarke commented Dec 17, 2019

Welcome to the world of app developers :). You might get an idea why I tend to not rush features but instead sit many out a bit longer to get things right (or leave them out altogether)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants