Skip to content

Conversation

buttcmd
Copy link
Contributor

@buttcmd buttcmd commented Jul 15, 2019

  • Translation to Spanish of the new functionalities (adapt to new Localizable strings order) (English flie used as source)
  • Corrections of some typos in English translation

César Arratia García added 2 commits July 15, 2019 10:18
…alizable strings order)

- Corrections of some typos in English translation
@mstarke
Copy link
Member

mstarke commented Jul 15, 2019

If you have access to Xcode the better way is to export the localization, edit it with a XLIFF tool and then re-import. This way you get updates to UI files as well since they are missing from the localizeable files. If you find the time you might push those changes to this PR

@buttcmd
Copy link
Contributor Author

buttcmd commented Jul 17, 2019

All the translations have been completed. You where right with XLIFF was easier

@mstarke
Copy link
Member

mstarke commented Jul 19, 2019

Awesome! I'm currently shuffling some UI aroung so there might be some changes in the future that will need more updates. Would it be ok for you if I ping you to ask for an update?

@mstarke mstarke merged commit 091a565 into MacPass:master Jul 19, 2019
@buttcmd
Copy link
Contributor Author

buttcmd commented Jul 19, 2019 via email

@buttcmd buttcmd deleted the FEATURE/translations branch July 19, 2019 14:47
@skyline75489
Copy link
Contributor

The zh-Hans translation is very outdated. I'm trying to update the Simplified Chinese translation using the xlifftool way.

I found there are some duplicate entrys. Some entrys seems to be unused, though. @mstarke Is there any plan to fix those. I found it confusing for tranlators like me.

@mstarke
Copy link
Member

mstarke commented Aug 3, 2019

I've tried to update as many translations as possible to use only used strings but I haven't touched Chinese. I will try to set this up so you can get on updating the translations. Awesome by the way!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants