Skip to content

Some unit tests fail #316

@dbogdanov

Description

@dbogdanov

Some regression tests are failing for some algorithms. Review and update the ground truth annotation.

PitchYinFFT

ERR FAIL: testARealCase (tonal.test_pitchyinfft.TestPitchYinFFT)
ERR ----------------------------------------------------------------------
ERR Traceback (most recent call last):
ERR   File "/data/go-agent/workspace/pipelines/afep-deps-libessentia/dependencies/libessentia/work/essentia-2.1_beta2/test/src/unittest/tonal/test_pitchyinfft.py", line 131, in testARealCase
ERR     self.assertAlmostEqualVector(pitch, expected_pitch)
ERR   File "/data/go-agent/workspace/pipelines/afep-deps-libessentia/dependencies/libessentia/work/essentia-2.1_beta2/test/src/unittest/essentia_test.py", line 115, in assertAlmostEqualVector
ERR     self.assertAlmostEqual(val1, val2, precision)
ERR   File "/data/go-agent/workspace/pipelines/afep-deps-libessentia/dependencies/libessentia/work/essentia-2.1_beta2/test/src/unittest/essentia_test.py", line 97, in assertAlmostEqual
ERR     self.assert_(diff <= precision, 'Difference is %e while allowed precision is %e' % (diff, precision))
ERR AssertionError: Difference is 1.141042e-02 while allowed precision is 1.000000e-07

Panning

ERR FAIL: testRegression (standard.test_panning.TestPanning)
ERR ----------------------------------------------------------------------
ERR Traceback (most recent call last):
ERR   File "/data/go-agent/workspace/pipelines/afep-deps-libessentia/dependencies/libessentia/work/essentia-2.1_beta2/test/src/unittest/standard/test_panning.py", line 78, in testRegression
ERR     self.assertAlmostEqualVectorFixedPrecision(expected[i], output[0], 2)
ERR   File "/data/go-agent/workspace/pipelines/afep-deps-libessentia/dependencies/libessentia/work/essentia-2.1_beta2/test/src/unittest/essentia_test.py", line 102, in assertAlmostEqualVectorFixedPrecision
ERR     self.assertAlmostEqualFixedPrecision(val1, val2, digits)
ERR   File "/data/go-agent/workspace/pipelines/afep-deps-libessentia/dependencies/libessentia/work/essentia-2.1_beta2/test/src/unittest/essentia_test.py", line 88, in assertAlmostEqualFixedPrecision
ERR     BaseTestCase.assertAlmostEqual(self, found, expected, digits)
ERR AssertionError: -49.7533 != -49.766972 within 2 places

RhythmExtractor (outdated algorithm, #3 )

FAIL: testImpulseTrain (rhythm.test_rhythmextractor.TestRhythmExtractor)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/dbogdanov/essentia/test/src/unittest/rhythm/test_rhythmextractor.py", line 308, in testImpulseTrain
    self.assertVectorWithinVector(result[1], expectedTicks, 0.03)
  File "/home/dbogdanov/essentia/test/src/unittest/rhythm/test_rhythmextractor.py", line 110, in assertVectorWithinVector
    self.assertAlmostEqual(found[i], expected[j-1], precision)
  File "/home/dbogdanov/essentia/test/src/unittest/essentia_test.py", line 97, in assertAlmostEqual
    self.assert_(diff <= precision, 'Difference is %e while allowed precision is %e' % (diff, precision))
AssertionError: Difference is 3.712006e-02 while allowed precision is 3.000000e-02

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions