[Hotfix] Fixe la sélection de période sur la liste des unités #918
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bd44fe5 to
c0ec84b
Compare
c0ec84b to
d9d5c3c
Compare
claire2212
approved these changes
Oct 26, 2023
claire2212
reviewed
Oct 26, 2023
| throw new FrontendError('`selectedValues` should be an array.') | ||
| } | ||
|
|
||
| const nextSelectedValues = selectedValues.filter(selectedValue => selectedValue !== valueToDelete) as |
There was a problem hiding this comment.
on a pas pris le parti de tout typer dans Env, vraiment que le métier (genre ici string[] | number[] n'est pas "nécessaire")
There was a problem hiding this comment.
Je suis d'accord qu'il n'y pas besoin d'absolument tout typer mais là c'est pour éviter une erreur TS qui pense que c'est (string | number)[] sinon le check ne passe pas :X.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Pull Requests & Issues
None