Skip to content

[WIP] Python3 port #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 16, 2019
Merged

[WIP] Python3 port #8

merged 2 commits into from
Oct 16, 2019

Conversation

Dawars
Copy link
Contributor

@Dawars Dawars commented May 11, 2019

I started porting the COMA repo and hence this dependency to Python 3.

I couldn't test these changes as described in issue #7 therefore it shouldn't be merged just yet.

Furthermore I propose creating a separate branch for the Python3 version. I don't have the means to create it.

@Dawars Dawars mentioned this pull request May 11, 2019
Open
@anuragranj
Copy link
Member

Thanks a lot @Dawars . We will review it as soon as possible and update the repository.
@jcpassy

@jcpassy
Copy link
Member

jcpassy commented Jul 15, 2019

Thanks @Dawars, I have created a branch for your PR. We will also test it against our private repository. More soon...

@jcpassy jcpassy changed the base branch from master to develop October 16, 2019 13:02
@jcpassy jcpassy merged commit b8cb50b into MPI-IS:develop Oct 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Dawars @anuragranj @jcpassy @shubham-goel