Fix news no stop #2897

ken-mycroft · 2021-05-04T11:34:27Z

Description

Fixes Jira SKILL-108

How to test

Try to stop the news playback using anything other than the word stop

Contributor license agreement signed?

yes

pep8speaks · 2021-05-04T11:34:36Z

Hello @ken-mycroft! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file mycroft/audio/audioservice.py:

Line 386:13: E722 do not use bare 'except'

In the file mycroft/client/enclosure/__main__.py:

Line 84:80: E501 line too long (91 > 79 characters)
Line 87:80: E501 line too long (135 > 79 characters)
Line 89:80: E501 line too long (86 > 79 characters)
Line 90:80: E501 line too long (81 > 79 characters)

In the file mycroft/client/enclosure/mark2/interface.py:

Line 91:25: E231 missing whitespace after ','
Line 92:34: E201 whitespace after '('
Line 92:49: E202 whitespace before ')'
Line 95:31: E201 whitespace after '('
Line 95:45: E202 whitespace before ')'
Line 111:35: E201 whitespace after '('
Line 111:49: E202 whitespace before ')'
Line 117:27: E201 whitespace after '('
Line 117:46: E202 whitespace before ')'
Line 129:28: E231 missing whitespace after ','
Line 141:29: E231 missing whitespace after ','
Line 149:27: E201 whitespace after '('
Line 149:30: E231 missing whitespace after ','
Line 149:32: E231 missing whitespace after ','
Line 149:35: E202 whitespace before ')'
Line 178:80: E501 line too long (117 > 79 characters)
Line 215:5: E303 too many blank lines (2)
Line 268:80: E501 line too long (80 > 79 characters)
Line 271:80: E501 line too long (80 > 79 characters)
Line 278:80: E501 line too long (85 > 79 characters)
Line 290:80: E501 line too long (101 > 79 characters)
Line 303:80: E501 line too long (94 > 79 characters)
Line 338:55: W291 trailing whitespace

In the file mycroft/client/speech/listener.py:

Line 110:80: E501 line too long (83 > 79 characters)

In the file mycroft/client/speech/mic.py:

Line 106:80: E501 line too long (86 > 79 characters)
Line 117:80: E501 line too long (81 > 79 characters)
Line 118:17: E722 do not use bare 'except'

In the file mycroft/enclosure/hardware/Mark2.py:

Line 19:22: E231 missing whitespace after ':'
Line 20:27: E231 missing whitespace after ':'
Line 20:35: E231 missing whitespace after ':'
Line 20:57: E231 missing whitespace after ':'
Line 21:30: E231 missing whitespace after ':'
Line 21:38: E231 missing whitespace after ':'
Line 21:60: E231 missing whitespace after ':'
Line 22:30: E231 missing whitespace after ':'
Line 22:38: E231 missing whitespace after ':'
Line 22:63: E231 missing whitespace after ':'
Line 22:80: E501 line too long (80 > 79 characters)
Line 23:27: E231 missing whitespace after ':'
Line 23:35: E231 missing whitespace after ':'
Line 23:57: E231 missing whitespace after ':'
Line 24:31: E231 missing whitespace after ':'
Line 24:39: E231 missing whitespace after ':'
Line 24:65: E231 missing whitespace after ':'
Line 24:80: E501 line too long (82 > 79 characters)
Line 26:23: E231 missing whitespace after ':'
Line 27:27: E231 missing whitespace after ':'
Line 27:35: E231 missing whitespace after ':'
Line 27:58: E231 missing whitespace after ':'
Line 28:30: E231 missing whitespace after ':'
Line 28:38: E231 missing whitespace after ':'
Line 28:64: E231 missing whitespace after ':'
Line 28:80: E501 line too long (81 > 79 characters)
Line 29:30: E231 missing whitespace after ':'
Line 29:38: E231 missing whitespace after ':'
Line 29:64: E231 missing whitespace after ':'
Line 29:80: E501 line too long (81 > 79 characters)
Line 30:31: E231 missing whitespace after ':'
Line 30:39: E231 missing whitespace after ':'
Line 30:65: E231 missing whitespace after ':'
Line 30:80: E501 line too long (82 > 79 characters)
Line 32:55: E231 missing whitespace after ':'
Line 33:27: E231 missing whitespace after ':'
Line 33:35: E231 missing whitespace after ':'
Line 33:59: E231 missing whitespace after ':'
Line 34:30: E231 missing whitespace after ':'
Line 34:38: E231 missing whitespace after ':'
Line 34:60: E231 missing whitespace after ':'
Line 35:30: E231 missing whitespace after ':'
Line 35:38: E231 missing whitespace after ':'
Line 35:64: E231 missing whitespace after ':'
Line 35:80: E501 line too long (81 > 79 characters)
Line 36:31: E231 missing whitespace after ':'
Line 36:39: E231 missing whitespace after ':'
Line 36:65: E231 missing whitespace after ':'
Line 36:80: E501 line too long (82 > 79 characters)
Line 38:54: E231 missing whitespace after ':'
Line 39:27: E231 missing whitespace after ':'
Line 39:35: E231 missing whitespace after ':'
Line 39:59: E231 missing whitespace after ':'
Line 40:30: E231 missing whitespace after ':'
Line 40:38: E231 missing whitespace after ':'
Line 40:60: E231 missing whitespace after ':'
Line 41:30: E231 missing whitespace after ':'
Line 41:38: E231 missing whitespace after ':'
Line 41:59: E231 missing whitespace after ':'
Line 42:31: E231 missing whitespace after ':'
Line 42:39: E231 missing whitespace after ':'
Line 42:65: E231 missing whitespace after ':'
Line 42:80: E501 line too long (82 > 79 characters)
Line 44:50: E231 missing whitespace after ':'
Line 45:27: E231 missing whitespace after ':'
Line 45:35: E231 missing whitespace after ':'
Line 45:58: E231 missing whitespace after ':'
Line 46:30: E231 missing whitespace after ':'
Line 46:38: E231 missing whitespace after ':'
Line 46:60: E231 missing whitespace after ':'
Line 47:30: E231 missing whitespace after ':'
Line 47:38: E231 missing whitespace after ':'
Line 47:64: E231 missing whitespace after ':'
Line 47:80: E501 line too long (81 > 79 characters)
Line 48:31: E231 missing whitespace after ':'
Line 48:39: E231 missing whitespace after ':'
Line 48:65: E231 missing whitespace after ':'
Line 48:80: E501 line too long (82 > 79 characters)
Line 51:5: E265 block comment should start with '# '
Line 52:5: E265 block comment should start with '# '
Line 53:5: E265 block comment should start with '# '

In the file mycroft/enclosure/hardware/MycroftFan/MycroftFan.py:

Line 20:43: W291 trailing whitespace
Line 38:1: W391 blank line at end of file

In the file mycroft/enclosure/hardware/MycroftFan/fan_sj201r4.py:

Line 1:10: E401 multiple imports on one line
Line 3:1: E302 expected 2 blank lines, found 1
Line 26:9: E722 do not use bare 'except'
Line 31:9: E722 do not use bare 'except'
Line 37:5: E303 too many blank lines (2)
Line 41:5: E303 too many blank lines (2)
Line 51:20: E201 whitespace after '('
Line 51:51: E202 whitespace before ')'
Line 54:5: E303 too many blank lines (2)
Line 64:15: E271 multiple spaces after keyword
Line 64:21: E201 whitespace after '('
Line 64:28: E201 whitespace after '('
Line 64:78: E203 whitespace before ','
Line 64:80: E501 line too long (85 > 79 characters)
Line 64:82: E202 whitespace before ')'
Line 64:84: E202 whitespace before ')'
Line 67:5: E303 too many blank lines (2)
Line 79:5: E303 too many blank lines (2)
Line 84:5: E303 too many blank lines (2)
Line 90:22: E201 whitespace after '('
Line 90:34: E202 whitespace before ')'
Line 91:1: W391 blank line at end of file

In the file mycroft/enclosure/hardware/MycroftLed/MycroftLed.py:

Line 34:80: E501 line too long (87 > 79 characters)
Line 37:1: W293 blank line contains whitespace
Line 69:1: W391 blank line at end of file

In the file mycroft/enclosure/hardware/MycroftLed/default_palette.py:

Line 3:15: E231 missing whitespace after ','
Line 3:17: E231 missing whitespace after ','
Line 4:17: E231 missing whitespace after ','
Line 4:21: E231 missing whitespace after ','
Line 6:15: E231 missing whitespace after ','
Line 6:17: E231 missing whitespace after ','
Line 7:15: E231 missing whitespace after ','
Line 7:19: E231 missing whitespace after ','
Line 8:14: E231 missing whitespace after ','
Line 8:16: E231 missing whitespace after ','
Line 9:19: E231 missing whitespace after ','
Line 9:21: E231 missing whitespace after ','
Line 10:24: E231 missing whitespace after ','
Line 10:27: E231 missing whitespace after ','
Line 11:23: E231 missing whitespace after ','
Line 11:26: E231 missing whitespace after ','
Line 12:24: E231 missing whitespace after ','
Line 12:28: E231 missing whitespace after ','
Line 13:23: E231 missing whitespace after ','
Line 13:27: E231 missing whitespace after ','

In the file mycroft/enclosure/hardware/MycroftLed/led_neo_pixel.py:

Line 42:80: E501 line too long (86 > 79 characters)

In the file mycroft/enclosure/hardware/MycroftLed/led_sj201r4.py:

Line 18:1: E302 expected 2 blank lines, found 1
Line 21:15: E231 missing whitespace after ','
Line 21:17: E231 missing whitespace after ','
Line 21:20: E261 at least two spaces before inline comment
Line 27:35: E231 missing whitespace after ':'
Line 28:37: E231 missing whitespace after ':'
Line 29:37: E231 missing whitespace after ':'
Line 30:40: E231 missing whitespace after ':'
Line 30:44: E231 missing whitespace after ','
Line 41:34: W291 trailing whitespace
Line 43:16: E221 multiple spaces before operator
Line 45:17: E221 multiple spaces before operator
Line 47:14: E222 multiple spaces after operator
Line 58:23: W291 trailing whitespace
Line 61:48: W291 trailing whitespace
Line 62:31: W291 trailing whitespace
Line 71:44: W291 trailing whitespace
Line 74:39: W291 trailing whitespace
Line 77:48: W291 trailing whitespace
Line 78:31: W291 trailing whitespace
Line 83:25: E231 missing whitespace after ','
Line 88:25: E231 missing whitespace after ','
Line 90:1: W391 blank line at end of file

In the file mycroft/enclosure/hardware/MycroftLed/led_xmos_usb.py:

Line 70:80: E501 line too long (87 > 79 characters)

In the file mycroft/enclosure/hardware/MycroftSwitch/MycroftSwitch.py:

Line 47:1: W391 blank line at end of file

In the file mycroft/enclosure/hardware/MycroftSwitch/switch_xmos_usb.py:

Line 18:80: E501 line too long (80 > 79 characters)

In the file mycroft/enclosure/hardware/MycroftVolume/MycroftVolume.py:

Line 20:46: W291 trailing whitespace
Line 38:1: W391 blank line at end of file

In the file mycroft/enclosure/hardware/MycroftVolume/volume_i2c.py:

Line 23:1: E302 expected 2 blank lines, found 1
Line 32:1: E302 expected 2 blank lines, found 1
Line 36:28: E231 missing whitespace after ':'
Line 36:33: E231 missing whitespace after ','
Line 37:27: E231 missing whitespace after ':'
Line 60:13: E265 block comment should start with '# '
Line 64:5: E303 too many blank lines (2)
Line 76:13: E265 block comment should start with '# '
Line 79:13: E265 block comment should start with '# '
Line 82:13: E265 block comment should start with '# '
Line 94:1: W391 blank line at end of file

In the file mycroft/enclosure/hardware/MycroftVolume/volume_sj201r4.py:

Line 18:80: E501 line too long (80 > 79 characters)
Line 123:80: E501 line too long (86 > 79 characters)
Line 124:80: E501 line too long (84 > 79 characters)

In the file mycroft/enclosure/hardware/MycroftVolume/volume_xmos_usb.py:

Line 17:80: E501 line too long (80 > 79 characters)

In the file mycroft/enclosure/hardware/util/neo_pixel_set_leds.py:

Line 19:65: W291 trailing whitespace
Line 21:23: W291 trailing whitespace
Line 24:58: W291 trailing whitespace
Line 25:55: W291 trailing whitespace
Line 28:9: W291 trailing whitespace
Line 31:54: W291 trailing whitespace
Line 36:77: W291 trailing whitespace
Line 46:19: E201 whitespace after '['
Line 46:48: E202 whitespace before ']'
Line 47:1: E722 do not use bare 'except'

In the file mycroft/enclosure/hardware_enclosure.py:

Line 46:80: E501 line too long (80 > 79 characters)
Line 49:64: W291 trailing whitespace
Line 56:80: E501 line too long (92 > 79 characters)
Line 96:24: E201 whitespace after '('
Line 96:43: E202 whitespace before ')'
Line 108:29: E201 whitespace after '('
Line 108:47: E202 whitespace before ')'
Line 111:29: E201 whitespace after '('
Line 111:48: E202 whitespace before ')'
Line 113:28: E201 whitespace after '('
Line 113:37: E202 whitespace before ')'
Line 118:39: E711 comparison to None should be 'if cond is not None:'
Line 137:39: W291 trailing whitespace
Line 138:44: W291 trailing whitespace
Line 142:39: W291 trailing whitespace
Line 143:42: W291 trailing whitespace
Line 148:80: E501 line too long (92 > 79 characters)
Line 157:80: E501 line too long (90 > 79 characters)
Line 167:24: E201 whitespace after '('
Line 167:43: E202 whitespace before ')'

In the file mycroft/skills/common_play_skill.py:

Line 168:80: E501 line too long (84 > 79 characters)

In the file mycroft/util/hardware_capabilities.py:

Line 3:1: E302 expected 2 blank lines, found 1
Line 5:41: W291 trailing whitespace
Line 16:80: E501 line too long (88 > 79 characters)
Line 17:80: E501 line too long (129 > 79 characters)
Line 18:80: E501 line too long (98 > 79 characters)
Line 24:80: E501 line too long (98 > 79 characters)
Line 53:9: E722 do not use bare 'except'
Line 58:9: E722 do not use bare 'except'
Line 64:5: E303 too many blank lines (2)
Line 71:13: E265 block comment should start with '# '
Line 81:47: E201 whitespace after '('
Line 81:55: E202 whitespace before ')'
Line 87:42: E201 whitespace after '('
Line 87:52: E202 whitespace before ')'
Line 89:32: W291 trailing whitespace
Line 96:13: E265 block comment should start with '# '
Line 106:13: E265 block comment should start with '# '
Line 116:13: E265 block comment should start with '# '
Line 122:29: E201 whitespace after '['
Line 122:80: E501 line too long (124 > 79 characters)
Line 122:123: E202 whitespace before ']'
Line 125:9: E303 too many blank lines (2)
Line 125:36: E231 missing whitespace after ':'
Line 125:59: E231 missing whitespace after ':'
Line 125:80: E231 missing whitespace after ':'
Line 125:80: E501 line too long (93 > 79 characters)

In the file test/unittests/api/test_api.py:

Line 216:80: E501 line too long (83 > 79 characters)
Line 220:80: E501 line too long (83 > 79 characters)
Line 224:80: E501 line too long (83 > 79 characters)

devops-mycroft · 2021-05-04T12:15:37Z

Voight Kampff Integration Test Succeeded (Results)

krisgesling

Nice one!

JarbasAl · 2021-05-06T13:36:52Z

mycroft/skills/common_play_skill.py

@@ -165,6 +165,8 @@ def __handle_play_start(self, message):
        # "... on the chromecast"
        self.play_service_string = phrase

+        self.bus.emit(Message('active_skill_request',  {'skill_id': self.skill_id}))


im late to the party, but theres a MycroftSkill method that handles this self.make_active()

It was getting called inconsistently based on match types. I deprecated it in the next PR

companion to news skill branch fix_no_stop

3e6a2a4

devops-mycroft added the CLA: Yes Contributor License Agreement exists (see https://github.com/MycroftAI/contributors) label May 4, 2021

krisgesling changed the base branch from dev to feature/mark-2 May 4, 2021 12:40

krisgesling mentioned this pull request May 6, 2021

Add Common Play to active Skills when invoked #2900

Merged

1 task

krisgesling approved these changes May 6, 2021

View reviewed changes

krisgesling merged commit cc31d85 into feature/mark-2 May 6, 2021

krisgesling deleted the fix_news_no_stop branch May 6, 2021 07:32

JarbasAl reviewed May 6, 2021

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix news no stop #2897

Fix news no stop #2897

Uh oh!

ken-mycroft commented May 4, 2021

Uh oh!

pep8speaks commented May 4, 2021

Uh oh!

devops-mycroft commented May 4, 2021

Uh oh!

krisgesling left a comment

Uh oh!

JarbasAl May 6, 2021

Uh oh!

ken-mycroft May 6, 2021

Uh oh!

Uh oh!

Fix news no stop #2897

Fix news no stop #2897

Uh oh!

Conversation

ken-mycroft commented May 4, 2021

Description

How to test

Contributor license agreement signed?

Uh oh!

pep8speaks commented May 4, 2021

Uh oh!

devops-mycroft commented May 4, 2021

Uh oh!

krisgesling left a comment

Choose a reason for hiding this comment

Uh oh!

JarbasAl May 6, 2021

Choose a reason for hiding this comment

Uh oh!

ken-mycroft May 6, 2021

Choose a reason for hiding this comment

Uh oh!

Uh oh!